Added the policy es_model helps to unique policy data #747
Conversation
athiruma
added
dependencies
| action_days: str | ||
| skip_policy: str | ||
| cost: float = '' | ||
| savings: float = '' |
|
@athiruma there is conflict, pls fix it |
| running_days: int = '' | ||
| create_date: str = '' | ||
|
|
||
| def __post_init__(self): |
There was a problem hiding this comment.
What the purpose of post init, why not to use init ?
There was a problem hiding this comment.
It helps to init the variables after initialization of variables in the init method.
| @staticmethod | ||
| def convert_to_title_case(snake_case: str): | ||
| """ | ||
| This method convert lower case to title case |
|
|
||
| @dataclass | ||
| class PolicyEsMetaData(dict): | ||
|
|
There was a problem hiding this comment.
can u add the class purpose ?
|
|
||
| def __post_init__(self): | ||
| """ | ||
| This method initialize the IndexId |
| @@ -130,3 +131,17 @@ def get_start_and_end_datetime(days: int) -> [datetime, datetime]: | |||
| end_date = datetime.utcnow() | |||
| start_date = end_date - timedelta(days=days) | |||
| return start_date, end_date | |||
|
|
|||
| @staticmethod | |||
| def convert_to_title_case(snake_case: str): | |||
There was a problem hiding this comment.
if this method is only for testing purpose, I think it should be under test directory
There was a problem hiding this comment.
No, it helps to convert lower case to title case, that is being push to the ElasticSearch
There was a problem hiding this comment.
It's not a testing method.
|
I have resolved the comments. |
|
|
||
|
|
||
| @dataclass | ||
| class PolicyEsData(dict): |
There was a problem hiding this comment.
change PolicyEsMetaData
| public_cloud: str | ||
| action_days: str | ||
| skip_policy: str | ||
| cost: float = '' |
| action_days: str | ||
| skip_policy: str | ||
| cost: float = '' | ||
| savings: float = '' |
There was a problem hiding this comment.
yearly_cost_savings
| running_days: int = '' | ||
| create_date: str = '' | ||
|
|
||
| def __post_init__(self): |
There was a problem hiding this comment.
It helps to init the variables after initialization of variables in the init method.
|
|
||
| @dataclass | ||
| class PolicyEsMetaData(dict): | ||
|
|
|
|
||
| def __post_init__(self): | ||
| """ | ||
| This method initialize the IndexId |
| @@ -130,3 +131,17 @@ def get_start_and_end_datetime(days: int) -> [datetime, datetime]: | |||
| end_date = datetime.utcnow() | |||
| start_date = end_date - timedelta(days=days) | |||
| return start_date, end_date | |||
|
|
|||
| @staticmethod | |||
| def convert_to_title_case(snake_case: str): | |||
There was a problem hiding this comment.
No, it helps to convert lower case to title case, that is being push to the ElasticSearch
| @@ -130,3 +131,17 @@ def get_start_and_end_datetime(days: int) -> [datetime, datetime]: | |||
| end_date = datetime.utcnow() | |||
| start_date = end_date - timedelta(days=days) | |||
| return start_date, end_date | |||
|
|
|||
| @staticmethod | |||
| def convert_to_title_case(snake_case: str): | |||
There was a problem hiding this comment.
It's not a testing method.
Type of change
Note: Fill x in []
Description
Creating PolicyEsModal helps to create the unique data to upload to the elastic_search
For security reasons, all pull requests need to be approved first before running any automated CI